Deno 0.34 - Strict types #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
reviewed
Mar 2, 2020
| for (i = 0; i < item.cells.length; i++) { | ||
| item.cells[i] = splitCells(item.cells[i], item.header.length); | ||
| for (i = 0; i < item.cells.length; i++) { //NOTE: risky conversion with toString? -@olaven | ||
| item.cells[i] = splitCells(item.cells[i].toString(), item.header.length); |
There was a problem hiding this comment.
Isn't Tokens.Table already dictates cells to be string[][]? Maybe explicitly mark item declaration to have type Table
Actually it seems that Tokens.Table type annotation of cells seems incorrect (it was copied from DefinitelyTyped) and should be string[].
There was a problem hiding this comment.
This may be. However, cells is treated as string[][] other places in the code. E.g. it is expected to be string[][] in 484, as splitCells returns string[].
Perhaps there is something I am not catching here? 😃
|
Thank you for taking a look! |
|
This also reveals that we might have to setup a CI for it. |
|
Is there anything else I can do in order to get this merged into master? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for porting this library!
It breaks with version 0.34 of Deno, released some days ago as strict typing is now enabled by default.
I have made an (imperfect, surely) attempt at supporting strict typing.
Please concider a merge, as strict typing seems to be a standard going forward. (relevant discussion)
Have a nice day!
Olav