-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EM860P2-N TOUCH] Configuration created no devices #44
Comments
Hi, Thank you for the feedback! I'm sorry, but unless there's problem with physical connection (incorrect wiring, bad RS485 converter, etc.), error Could you please provide full model number so I can check? |
Warn user when encountering unknown parameters. Related to: denpamusic/homeassistant-plum-ecomax#44
Hi |
OK. I've never seen your model in use by any other users of this integration, so sadly I cannot confirm that it's compatible. I've made this change to allow for more graceful handling of cases like yours. Now PyPlumIO will at least try to work with what parameters it knows, instead of completely giving up, when encountering unknown. This change will be included into next stable release, which is scheduled for November, 15th. Please wait until this release and try again. Hopefully your controller just have some extra parameters on top, with the main parameters table intact. Thanks again for the feedback and sorry for the inconvenience! |
Thank you. |
Hi |
Sorry, I forgot to mention it here, this release 0.3.16 doesn't include changes for your device as it is still based on PyPlumIO 0.4.14. You should update to integration release 0.4.1 beta, once it comes out. 0.4.1 will be first release based on the PyPlumIO 0.5.x, which includes changes for your device and many-many more. As I expect things to break due to sheer amount of breaking changes introduced in PyPlumIO 0.5.x, I decided to do a tiny release, so that people can downgrade, if they encountered any errors. Sorry for the inconvenience and please wait for 0.4.1, it will be out in a couple of days. |
Thanks for the clarification. |
You can now try to install v0.4.1-beta.2 by following this guide, but selecting This version contains a more graceful handling of unknown parameters. It will warn you about unknown parameter in the log and continue, instead completely failing like previous versions did. Please note, that it doesn't necessary mean that everything will be working fine, because here we assume that Plum added new parameters onto regular EM860p parameters table instead of completely reinventing the whole table for your model. If the whole parameters table is completely different from the one we know, it won't work. Then I'll need to develop a quick tool to obtain |
Hello |
Thank you for heads up and especially for diagnostics! Could you please clarify which parameters report incorrect values? From your diagnostics, I see that a least some parameters, like "heating_target_temp" below, work fine. {
"heating_target_temp": {
"__type": "<class 'pyplumio.structures.ecomax_parameters.EcomaxParameter'>",
"repr": "EcomaxParameter(device=EcoMAX, values=ParameterValues(value=62, min_value=55, max_value=80), description=EcomaxParameterDescription(name='heating_target_temp', unit_of_measurement=<UnitOfMeasurement.CELSIUS: '\u00b0C'>, multiplier=1, offset=0), index=98)"
}
} edit. |
When getting schedule name from the parameter name, PyPlumIO incorrectly split parameter name on first "_"(underscore), which lead to only "water" schedule name being extracted from "water_heater_schedule_switch" parameter name, instead of "water_heater". Related to: denpamusic/homeassistant-plum-ecomax#44
The following is mostly for myself, to keep track of the issue:
{
"frame_versions": {
"26": 0,
"85": 15534,
"84": 28411,
"86": 34385,
"54": 2,
"56": 15,
"57": 2,
"61": 64682
}
} For comparison here's versioning table from EM850P2-C {
"frame_versions": {
"49": 140,
"50": 140,
"54": 1,
"56": 122,
"57": 7,
"61": 3591,
"80": 1,
"81": 1,
"82": 1,
"83": 1,
"92": 64421,
"94": 0,
"95": 126,
"88": 22768,
"62": 56014
}
} That being said, this error by itself shouldn't actually impact the ability to set parameters. It only impacts ability to confirm that said parameters was correctly set. One way to resolve this, would be to redo confirmation logic to re-request parameters manually after sending SetEcomaxParameterRequest instead of delegating this task to versioning handler. This has drawback of requesting parameters twice on the devices that do have frame 49 in their versioning table, but I believe that will be acceptable price to pay, without getting complicated with different logic for different models, especially with the recent performance improvements. |
Is there an existing issue for this?
I'm having the following issue:
Integration is added to Homeassistant, configuration created, no devices or entities. Configuration failed. Retrying the configuration. Configuration failure... And so on.
I have following devices connected:
I'm connecting to my devices using:
USB to RS-485 adapter
I'm seeing following log messages:
My diagnostics data:
No device - no diagnostic data
Code of Conduct
The text was updated successfully, but these errors were encountered: