Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 18519 - fix for online scheduling link #2183

Merged

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Jul 15, 2024

Summary

  • Makes conditional assignment that doesn't work in liquid into a conditional that assigns a boolean.
  • Sitewide

Related issue(s)

Testing done

  • Manually tested changing the online scheduling link on tugboats and viewing the results.

Screenshots

VBA SL with link Screenshot 2024-07-15 at 4 01 51 PM
VBA SL without link Screenshot 2024-07-15 at 4 02 03 PM
VAMC SL with link Screenshot 2024-07-15 at 4 01 02 PM
VAMC without link Screenshot 2024-07-15 at 4 04 32 PM

What areas of the site does it impact?

Service Location paragraph online scheduling links

Acceptance criteria

  • Online scheduling link is visible for VBA when set to yes in drupal
  • Online scheduling link is visible for VAMC when set to yes in drupal
  • Reviewed by @laflannery

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

View:
https://web-codylbelkq0gdivw6x7tykigmeqloewe.demo.cms.va.gov/philadelphia-va-regional-benefit-office
and
https://web-codylbelkq0gdivw6x7tykigmeqloewe.demo.cms.va.gov/honolulu-va-regional-benefit-office-at-spark-m-matsunaga-department-of-veterans-affairs-medical-center
(^this one doesn't seem to want to load are we sure it works when published?)

and
https://web-codylbelkq0gdivw6x7tykigmeqloewe.demo.cms.va.gov/boston-health-care/locations/jamaica-plain-va-medical-center/#mental-health-care

@eselkin eselkin marked this pull request as ready for review July 15, 2024 23:07
@eselkin eselkin requested a review from a team as a code owner July 15, 2024 23:07
@eselkin eselkin requested a review from laflannery July 15, 2024 23:08
Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@randimays randimays merged commit 2cfe33c into main Jul 16, 2024
27 checks passed
@randimays randimays deleted the VACMS-18519-OnlineSchedulingLink-make-conditional-correct branch July 16, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants