Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 13937 - VAMC and Vet Center Accordions with text to select a subject #2187

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Jul 16, 2024

Summary

  • Adds text below header to identify that a user should select a topic for more information in the form of the statement: "Select a topic to learn more."
  • Sitewide team

Related issue(s)

Testing done

  • Manually tested several VAMC and Vet Center locations

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

VAMC Prepare for your visit (desktop) - in PR Screenshot 2024-07-16 at 3 14 23 PM
VAMC Prepare for your visit (mobile) - in PR Screenshot 2024-07-16 at 3 14 33 PM
VAMC Prepare for your visit (desktop) - current Screenshot 2024-07-16 at 3 15 59 PM
VAMC Health Services (desktop) in PR Screenshot 2024-07-16 at 3 17 09 PM
VAMC Health Services (mobile) in PR Screenshot 2024-07-16 at 3 18 00 PM
VAMC Health Services (desktop) - current Screenshot 2024-07-16 at 3 18 57 PM
Vet Center Prepare for your visit (desktop) - current Screenshot 2024-07-16 at 3 20 24 PM
Vet Center Prepare for your visit (desktop) - in PR Screenshot 2024-07-16 at 3 21 44 PM
Vet Center Services (desktop) - in PR Screenshot 2024-07-16 at 3 22 35 PM
Vet Center Services (desktop) - current Screenshot 2024-07-16 at 3 23 33 PM

What areas of the site does it impact?

VAMC and Vet Center pages (unauthenticated)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user (unauthenticated)

Requested Feedback

View screenshots or RI or build locally (can use regular build step pulling from any tugboat or the default).
Go to
http://1a0644201a521249e3b19ac3dd9f0b29.review.vetsgov-internal/boston-vet-center/
and
http://1a0644201a521249e3b19ac3dd9f0b29.review.vetsgov-internal/philadelphia-health-care/locations/corporal-michael-j-crescenz-department-of-veterans-affairs/

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-13937-Select-a-topic-to-learn-more-on-most-accordions-vamc-vet-center July 16, 2024 22:18 Inactive
@eselkin eselkin marked this pull request as ready for review July 17, 2024 23:14
@eselkin eselkin requested a review from a team as a code owner July 17, 2024 23:14
@eselkin eselkin requested review from a team as code owners July 18, 2024 19:19
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-13937-Select-a-topic-to-learn-more-on-most-accordions-vamc-vet-center July 18, 2024 20:34 Inactive
@eselkin eselkin requested a review from laflannery July 19, 2024 19:39
@eselkin eselkin merged commit bc2947d into main Jul 23, 2024
24 checks passed
@eselkin eselkin deleted the VACMS-13937-Select-a-topic-to-learn-more-on-most-accordions-vamc-vet-center branch July 23, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants