Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18523: Remove unused code for Merger-crosslinks.html #2191

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Jul 18, 2024

Summary

This PR removes unused code for the merger-crosslinks.html file that was flagged to need an upgrade to va-link. This PR also takes care of imports of this file and I checked for unused styles as well but they are still being used elsewhere.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#18523

Testing done

Make sure no usage of removed code and tests passing.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/18523-merger-links July 18, 2024 20:34 Inactive
@chriskim2311 chriskim2311 marked this pull request as ready for review July 22, 2024 15:38
@chriskim2311 chriskim2311 requested review from a team as code owners July 22, 2024 15:38
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup; thank you!

@chriskim2311 chriskim2311 merged commit 179d2c7 into main Jul 22, 2024
24 checks passed
@chriskim2311 chriskim2311 deleted the 18523-merger-links branch July 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants