Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32-Added mock form ae design patterns app in registry.json #2199

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

bellepx0
Copy link
Contributor

Summary

Team: Authenticated Experience Design Patterns
Adds a registry entry for the newly created mock form ae design patterns app in vets-website. This needs to be merged after the related PR for vets-website

Related issue(s)

Testing done

No additional testing needed.

Screenshots

N/A

What areas of the site does it impact?

N/A

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@bellepx0 bellepx0 requested a review from adamwhitlock1 July 24, 2024 19:30
@bellepx0 bellepx0 requested review from a team as code owners July 24, 2024 19:30
Copy link
Contributor

@adamwhitlock1 adamwhitlock1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@bellepx0 bellepx0 merged commit c661ff6 into main Jul 29, 2024
24 checks passed
@bellepx0 bellepx0 deleted the bp-32-mock-form-ae-design-patterns-app branch July 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants