Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update burials-ez breadcrumbs #2383

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

ToddWebDev
Copy link
Contributor

Summary

Remove the 'Home' breadcrumb since it is redundant to the 'Va.gov home' breadcrumb

Issue

Testing done

Manual testing

Screenshots

Desktop

Before After
Screenshot 2024-12-10 at 1 04 09 PM Screenshot 2024-12-10 at 1 06 28 PM

Mobile

Before After
Screenshot 2024-12-10 at 1 10 04 PM Screenshot 2024-12-10 at 1 10 04 PM

What areas of the site does it impact?

Breadcrumbs

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@ToddWebDev ToddWebDev linked an issue Dec 10, 2024 that may be closed by this pull request
2 tasks
@ToddWebDev ToddWebDev added the burial-benefits Label used for Pull Requests that impact Burial claims (530) label Dec 10, 2024
Copy link

@balexandr balexandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToddWebDev ToddWebDev marked this pull request as ready for review December 10, 2024 21:40
@ToddWebDev ToddWebDev requested review from a team as code owners December 10, 2024 21:40
@ToddWebDev ToddWebDev merged commit 835fe2e into main Dec 13, 2024
27 checks passed
@ToddWebDev ToddWebDev deleted the burials-98454-update-breadcrumbs branch December 13, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
burial-benefits Label used for Pull Requests that impact Burial claims (530)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Burial | Breadcrumb issue
4 participants