Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS - Add useMemo and useCallback to useSnackbar hook #603

Open
3 tasks done
narin opened this issue Dec 6, 2024 · 1 comment · May be fixed by #617
Open
3 tasks done

DS - Add useMemo and useCallback to useSnackbar hook #603

narin opened this issue Dec 6, 2024 · 1 comment · May be fixed by #617
Assignees
Labels
design-system front-end Ticket requires front-end work

Comments

@narin
Copy link
Contributor

narin commented Dec 6, 2024

Description

As part of the Snackbar implementation, the Mobile Feature Support team reported that they needed to patch our useSnackbar hook for usage in the app. They specifically ran into issues when a Snackbar was shown, and then hidden due to navigation change. They mentioned that issue is likely because Snackbar was being called as part of a useEffect on one of the app screens and thus had to be included in the useEffect dependency array, and this caused some side effects without the memoization of useSnackbar

Acceptance Criteria

  • Examine the updates in the patch that was created
  • Apply the changes in the patch to useSnackbar if they make sense
  • Test in Storybook and within the app
@narin narin added design-system front-end Ticket requires front-end work labels Dec 6, 2024
@narin narin changed the title DS - Add useMemo and useCallback to useSnackbar DS - Add useMemo and useCallback to useSnackbar hook Dec 6, 2024
@oddballdave oddballdave self-assigned this Jan 6, 2025
@oddballdave oddballdave linked a pull request Jan 7, 2025 that will close this issue
14 tasks
@jennb33
Copy link
Collaborator

jennb33 commented Jan 8, 2025

1/8/2025 - Jennifer to follow up with Don on PR approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-system front-end Ticket requires front-end work
Projects
None yet
3 participants