4: [ART] Tweak var names in return URL fn (#34036)

department-of-veterans-affairs · Jan 17, 2025 · a5d1051 · a5d1051
1 parent 4f28052
commit a5d1051
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/applications/accredited-representative-portal/utilities/constants.js b/src/applications/accredited-representative-portal/utilities/constants.js
@@ -13,7 +13,7 @@ import {
 const USIP_PATH = '/sign-in';
 const USIP_BASE_URL = environment.BASE_URL;
 
-const baseReturnUrl =
+const BASE_RETURN_URL =
   externalApplicationsConfig[USIP_APPLICATIONS.ARP].externalRedirectUrl;
 
 export const getSignInUrl = ({ returnUrl } = {}) => {
@@ -22,8 +22,12 @@ export const getSignInUrl = ({ returnUrl } = {}) => {
   url.searchParams.set(USIP_QUERY_PARAMS.OAuth, true);
 
   if (returnUrl) {
-    const returnUrlPrefix = new URL(returnUrl).href.replace(baseReturnUrl, '');
-    url.searchParams.set(USIP_QUERY_PARAMS.to, returnUrlPrefix);
+    const returnUrlSuffix = new URL(returnUrl).href.replace(
+      BASE_RETURN_URL,
+      '',
+    );
+
+    url.searchParams.set(USIP_QUERY_PARAMS.to, returnUrlSuffix);
   }
 
   return url;