Skip to content

Commit

Permalink
EDM-451 456 496 SOB Updates (#34133)
Browse files Browse the repository at this point in the history
* edm-451 456 496 sob updates

* edm-456 update text
  • Loading branch information
flex2016 authored Jan 16, 2025
1 parent f59cfff commit f5b716e
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ function UserInfoSection({ enrollmentData = {}, showCurrentAsOfAlert }) {
<InfoPair
label="Date of birth"
name="dateOfBirth"
value={formatDateParsedZoneLong(enrollmentData.dateOfBirth)}
value={
enrollmentData?.dateOfBirth
? formatDateParsedZoneLong(enrollmentData.dateOfBirth)
: 'Unavailable'
}
additionalClass="section-line"
/>
<InfoPair
Expand Down
26 changes: 19 additions & 7 deletions src/applications/post-911-gib-status/containers/StatusPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,24 @@ class StatusPage extends React.Component {
<p>
You can print your statement and use it as a replacement for a
Certificate of Eligibility (COE) to show that you qualify for
benefits.
benefits. This statement only includes entitlement earned through
your own military service. If you recently transferred entitlement,
it may not be reflected here.
</p>
<p>
The Supreme Court’s Rudisill decision may increase your months of
entitlement if you have two or more qualifying periods of active
duty.
</p>
<va-link
href="https://benefits.va.gov/gibill/rudisill.asp"
text="Learn more about requesting a Rudisill review"
/>
</div>
);

printButton = (
<div className="section">
<div className="section vads-u-margin-top--4">
<VaButton
text="Get printable statement of benefits"
onClick={this.navigateToPrint}
Expand All @@ -56,7 +67,7 @@ class StatusPage extends React.Component {
{printButton}
<UserInfoSection enrollmentData={enrollmentData} />
<h3>How can I see my Post-9/11 GI Bill benefit payments?</h3>
<div>
<div className="vads-u-margin-bottom--4">
If you've received education benefit payments through this
program,{' '}
<a href="/va-payment-history/payments/">
Expand All @@ -66,10 +77,11 @@ class StatusPage extends React.Component {
</div>
<VaNeedHelp>
<div slot="content">
<p>
Call us at <VaTelephone contact="8008271000" />. We're here
Monday through Friday, 8:00 a.m to 9:00 p.m ET. If you have
hearing loss, call <VaTelephone contact="711" tty="true" />.
<p className="vads-u-margin-top--0">
Call 888-GI-BILL-1 (<VaTelephone contact="8884424551" />
). We're here from Monday through Friday, 8:00 a.m to 7:00 p.m
ET. If you have hearing loss, call{' '}
<VaTelephone contact="711" tty="true" />.
</p>
</div>
</VaNeedHelp>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
margin-bottom: 5em;

h3 {
margin: 1em 0 .5em 0;
padding: 0 0 .25em 0;
margin-bottom: 8.5px;
padding: 0;
}

hr {
Expand All @@ -16,18 +16,20 @@
margin-top: 1em;
margin-bottom: 1em;
}
h2 {
margin-top: 0;
}

.section {
margin-bottom: 2em;
}

.section-line {
margin-bottom: .25em;
margin-bottom: 0.25em;
}
#benefit-level {
margin-top: 2em;
}

/*.usa-alert {
margin: 1em 0 1em 0;
}*/

.not-qualified h5 {
margin-top: 1em;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,29 @@ describe('<UserInfoSection>', () => {
expect(benefitEndDate.text()).to.contain('Since you’re on active duty');
});
});
describe('date of birth InfoPair', () => {
it('should display the formatted date of birth if present', () => {
const tree = SkinDeep.shallowRender(<UserInfoSection {...props} />);
const dobInfoPair = tree
.everySubTree('InfoPair')
.find(pair => pair.props.label === 'Date of birth');
expect(dobInfoPair).to.exist;
expect(dobInfoPair.props.value).to.equal('November 12, 1995');
});

it('should display "Unavailable" if dateOfBirth is missing', () => {
// Create a copy of props but remove dateOfBirth
const noDobProps = _.merge({}, props, {
enrollmentData: {
dateOfBirth: null,
},
});
const tree = SkinDeep.shallowRender(<UserInfoSection {...noDobProps} />);
const dobInfoPair = tree
.everySubTree('InfoPair')
.find(pair => pair.props.label === 'Date of birth');
expect(dobInfoPair).to.exist;
expect(dobInfoPair.props.value).to.equal('Unavailable');
});
});
});

0 comments on commit f5b716e

Please sign in to comment.