-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travel Pay / add content + functionality to question pages #33979
Open
liztownd
wants to merge
70
commits into
main
Choose a base branch
from
liz/flesh-out-question-pages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+871
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-question-pages/main
January 13, 2025 18:37
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-question-pages/main
January 13, 2025 19:08
Inactive
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-question-pages/main
January 13, 2025 19:20
Inactive
seesleestak
reviewed
Jan 13, 2025
src/applications/travel-pay/components/submit-flow/pages/AddressPage.jsx
Show resolved
Hide resolved
src/applications/travel-pay/tests/containers/TravelPayStatusApp.unit.spec.jsx
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-question-pages/main
January 13, 2025 21:50
Inactive
seesleestak
reviewed
Jan 14, 2025
src/applications/travel-pay/components/submit-flow/pages/AddressPage.jsx
Show resolved
Hide resolved
seesleestak
reviewed
Jan 15, 2025
src/applications/travel-pay/components/submit-flow/pages/MileagePage.jsx
Show resolved
Hide resolved
seesleestak
approved these changes
Jan 15, 2025
kjduensing
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
va-vfs-bot
temporarily deployed
to
master/liz/flesh-out-question-pages/main
January 16, 2025 20:58
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
(Summarize the changes that have been made to the platform)
(Which team do you work for, does your team own the maintenance of this component?)
Travel Pay
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)
Target beginning for phased rollout is 2/1/25
Related issue(s)
Link to ticket created in va.gov-team repo
#10017
#10018
#10019
Link to epic if not included in ticket
#83829
Testing done
Describe what the old behavior was prior to the change
Pages were shells, no functionality
Describe the steps required to verify your changes are working as expected
Visit
/my-health/travel-pay/file-new-claim/{any made up appt id}
. Click the "File a new claim" link. Each of the 3 questions should have an associated radio button and content on the page.Describe the tests completed and the results
Updated unit test for each of the 3 pages and the cypress test for the submit functionality.
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Travel Pay
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?