-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - Aedp/aw/275/contact info prefill updates #33983
Draft
adamwhitlock1
wants to merge
16
commits into
main
Choose a base branch
from
aedp/aw/275/ContactInfo-prefill-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,193
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ContactInfo-prefill-updates
va-vfs-bot
temporarily deployed
to
master/aedp/aw/275/ContactInfo-prefill-updates/main
January 8, 2025 21:19
Inactive
va-vfs-bot
temporarily deployed
to
master/aedp/aw/275/ContactInfo-prefill-updates/main
January 9, 2025 02:16
Inactive
va-vfs-bot
temporarily deployed
to
master/aedp/aw/275/ContactInfo-prefill-updates/main
January 9, 2025 07:17
Inactive
adamwhitlock1
changed the title
Aedp/aw/275/contact info prefill updates
[WIP] - Aedp/aw/275/contact info prefill updates
Jan 9, 2025
va-vfs-bot
temporarily deployed
to
master/aedp/aw/275/ContactInfo-prefill-updates/main
January 9, 2025 16:20
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Standardizing the Personal Information / Veteran Information page to adhere to the Prefill Pattern that was developed by our team.
The overall structure would allow a function to be called to have a 'fully functioning' page to display the users name, date of birth, and last four of social security
Optional configuration can be passed to function to do a couple other things to accommodate different teams
dataAdapter
can be provided to define where the data resides that is shown on this page from within the form data object. An example might be that the ssn lives nested inside the form data atveteran.lastFourOfSSN
, so the this adapter can be used to specify that path, so the ssn is accessed correctly for the page to display it. The default is the pathssn
personalInfoConfig
object can be specified whether or not certain fields should be shown on the personalInformation page, because that is something that is present on some applications.Related issue(s)
department-of-veterans-affairs/va.gov-team#0000
department-of-veterans-affairs/vets-website#0000
department-of-veterans-affairs/va.gov-team#0000
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?