Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0966 new confirmation page followups #34101

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

rhasselle-oddball
Copy link
Contributor

Summary

All changes only apply to dev.va.gov for now for testing

  • Add new suggestions from UX
  • refactor next steps section for confirmation v2

Related issue(s)

  • Link to ticket created in va.gov-team repo
    department-of-veterans-affairs/va.gov-team-forms#1935

Testing done

  • unit, browser, regression

Screenshots

image

What areas of the site does it impact?

0966 new confirmation page on dev only currently.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@rhasselle-oddball rhasselle-oddball requested review from a team as code owners January 15, 2025 16:45
<ConfirmationView.WhatsNextProcessList
item2Content={
submissionApi === submissionApis.BENEFITS_INTAKE ? (
{submissionApi === submissionApis.BENEFITS_INTAKE && (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note all the code that uses ConfirmationView is gated to only dev currently, so we can test before pushing to prod.

Copy link
Contributor

@pennja pennja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work! 👍

@rhasselle-oddball rhasselle-oddball force-pushed the 1935-0966-new-confirmation-page-2 branch from 925abac to ab7bb3a Compare January 17, 2025 15:04
@rhasselle-oddball rhasselle-oddball merged commit 6af0335 into main Jan 17, 2025
79 checks passed
@rhasselle-oddball rhasselle-oddball deleted the 1935-0966-new-confirmation-page-2 branch January 17, 2025 16:22
rhasselle-oddball added a commit that referenced this pull request Jan 17, 2025
* 0966 followup changes for confirmation page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants