Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[99786] Appoint a Rep add submission types to search results #34105

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented Jan 15, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This pr adds a submission types sentence to search results in Appoint a Rep
  • This new content should only show when V2 is enabled AND the user has an ICN AND the user has a participant id

Related issue(s)

Testing done

  • Went through flow with authed and unauthed users. Also used the local constant to turn V2 on/off.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile image image
Desktop image image

What areas of the site does it impact?

Appoint a Rep Form 21-22 and 21-22a

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

const submissionTypeContent = v2IsEnabled &&
userIsDigitalSubmitEligible && (
<p data-testid="submission-methods">
Accepts VA Form {formNumber} online, by mail, and in person
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assume for now that all reps/orgs can accept all types

@jvcAdHoc
Copy link
Contributor Author

There will be some cleanup/refactoring to do once the submission method storage is implemented

@jvcAdHoc jvcAdHoc marked this pull request as ready for review January 15, 2025 18:51
@jvcAdHoc jvcAdHoc requested review from a team as code owners January 15, 2025 18:51
cosu419
cosu419 previously approved these changes Jan 15, 2025
Copy link
Contributor

@cosu419 cosu419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jvcAdHoc jvcAdHoc force-pushed the 99786-representative-select-add-submission-methods-to-rep-search-results branch from 4f92631 to 566465b Compare January 17, 2025 15:19
@jvcAdHoc jvcAdHoc requested review from cosu419 and a team January 17, 2025 15:19
@jvcAdHoc
Copy link
Contributor Author

Requesting re-review after resolving merge conflicts

@jvcAdHoc jvcAdHoc merged commit 1913280 into main Jan 17, 2025
70 checks passed
@jvcAdHoc jvcAdHoc deleted the 99786-representative-select-add-submission-methods-to-rep-search-results branch January 17, 2025 16:42
rhasselle-oddball pushed a commit that referenced this pull request Jan 17, 2025
* add submission types to search results

* fix spec nesting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appoint-a-representative Benefits Representation Management product label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants