Refactor forms-system onBack, routing, BackLink #34118
Conversation
rhasselle-oddball
force-pushed
the
1972-forms-system-updates-minimal-header
branch
from
c077d75 to
656710c
Compare
va-vfs-bot
temporarily deployed
to
master/1972-forms-system-updates-minimal-header/main
| @@ -1,4 +1,4 @@ | |||
| import { createRoutes } from 'platform/forms-system/src/js/routing'; | |||
| import { createRoutes } from 'platform/forms-system/src/js/routing/createRoutes'; | |||
There was a problem hiding this comment.
There was a cyclical dependency here, so just did some refactoring (should be no change)
| @@ -14,58 +13,68 @@ import { setData as setDataAction } from '../actions'; | |||
| * ```jsx | |||
| * <BackLink /> | |||
| * ``` | |||
| * | |||
There was a problem hiding this comment.
this code only affects forms using useTopBackLink property in their form config, which is 3 forms currently:
- mhv-supply-reordering
- 21-4138
- mock-form-minimal-header
None of these are currently enabled on prod.
| @@ -0,0 +1,68 @@ | |||
| import { createFormPageList, createPageList } from '../helpers'; | |||
There was a problem hiding this comment.
should be no change here. just moved this function from the above routing.js to remove the cyclical dependency with FormPage
| ); | ||
| } | ||
|
|
||
| export function goBack({ |
There was a problem hiding this comment.
this function and the below function is new. the code above this was just migrated from routing.js
| router, | ||
| setData, | ||
| }) { | ||
| const path = getPreviousPagePath(pageList, formData, location.pathname); |
There was a problem hiding this comment.
this code should match exactly what was in FormPage onBack. Extracted so that other places besides FormPage could use this too.
| @@ -640,11 +640,11 @@ va-accordion-item[data-unviewed-pages="true"] { | |||
| } | |||
|
|
|||
| .schemaform-confirmation-section-header { | |||
| font-size: $h3-font-size; | |||
| font-size: $font-size-h3; | |||
There was a problem hiding this comment.
these specific css props seemed to have broke recently. this fixes it.
rhasselle-oddball
force-pushed
the
1972-forms-system-updates-minimal-header
branch
from
656710c to
53b6c21
Compare
Summary
FormPage'sonBackso that it can be used in multiple placesBackLink(only used in a few places currently) to useonBackandva-linkRelated issue(s)
department-of-veterans-affairs/va.gov-team-forms#1972
Testing done
/supporting-forms-for-claims/statement-to-support-claim-form-21-4138which uses BackLink/mock-form-minimal-header/with array builder (not committed yet)Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?