96383 remove environment checks for for prod launch and update e2e tests #34141
+57
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinec-fftc
added
the
disability-compensation
5 tasks
va-vfs-bot
temporarily deployed
to
master/dbex/96383-5103-launch/main
christinec-fftc
commented
Jan 17, 2025
| cy.get(`va-checkbox[id="veteran-certify"]`) | ||
| .shadow() | ||
| .find('input') | ||
| .click({ force: true }); |
There was a problem hiding this comment.
fyi these changes were needed since the statement of truth section was recently updated in platform to use the VaStatementOfTruth component, so we now have a web component embedded with web components. since the inputs were in a shadow dom, we could no longer access the input and checkbox fields directly, hence the use of .shadow()
mchae-nava
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
team: @department-of-veterans-affairs/dbex-trex
flipper: none
Related issue(s)
department-of-veterans-affairs/va.gov-team#96383
Testing done
Screenshots
n/a
What areas of the site does it impact?
526ez
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?