-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ignore conditions nil error #9560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like #7787 fixed the |
The tests in #7787 were ineffective as it used the wrong key By making |
abdulapopoola
approved these changes
Apr 22, 2024
I still don't have my permissions back, so I can't approve this PR, but LGTM |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9457
This adds the stacktrace to the logs which allowed me to track down one of the other issues in #9457.
In job.json we started sending
updated-at
in the ignore conditions so it could be used for sorting, but here in the code it was used incorrectly asupdated_at
.Then later when types were applied, a
T.must
was added which always fails because neithercreated_at
norcreated-at
are ever sent in the payload.It would be best if
job.rb
immediately parsed thejob.json
into types and passed those around instead of hashes. That would help avoid this problem in the future.From what I can tell,
updated-at
should always be sent, but I was a bit defensive and set the time to the epoch for any that don't have that field set.