Fixes for max CPU count of 64 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Linux kernels are configured to allow "CPU hotswap" which means they pretend to have some huge array (128) of CPUs that might come online. This is weird. If we ask for the number of online CPUs that should be a saner value. std::thread::concurrency has the same issue, I think it uses the total count, which seems like a pretty bad bug in itself but outside the scope of this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change static arrays to dynamically allocated arrays. I think we can afford two allocations per run of the tool.
The root cause was a bug where a copy of the configuration was taken before the clamp was applied.
However I'm still not sure why some Linux distributions lie and pretend to have 128 CPUs.
Fixes #346