Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for max CPU count of 64 #347

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Fixes for max CPU count of 64 #347

merged 4 commits into from
Aug 4, 2024

Commits on Aug 4, 2024

  1. Remove warning about misleading indentation.

    @deplinenoise
    deplinenoise committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    c54852f View commit details
    Browse the repository at this point in the history

  2. Allow any number of build threads

    @deplinenoise
    deplinenoise committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    f3bb549 View commit details
    Browse the repository at this point in the history

  3. Use _SC_NPROCESSORS_ONLN to find online CPUs only 

    Some Linux kernels are configured to allow "CPU hotswap" which means
they pretend to have some huge array (128) of CPUs that might come
online. This is weird. If we ask for the number of online CPUs that
should be a saner value.

std::thread::concurrency has the same issue, I think it uses the total
count, which seems like a pretty bad bug in itself but outside the scope
of this project.
    @deplinenoise
    deplinenoise committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    76ca4e5 View commit details
    Browse the repository at this point in the history

  4. Allocate scratch handle array on Windows dynamically

    @deplinenoise
    deplinenoise committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    03ff325 View commit details
    Browse the repository at this point in the history