Forward default nodes as lookup table in ide file generation #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leidegre
force-pushed
the
feature/ide-gen-with-default-nodes
branch
from
d10fb72
to
a89ab85
Compare
|
Okay, so there was a bunch of trailing whitespace everywhere that according to the .editorconfig file should be removed, it made the diff a bit confusing so I made damn sure to not mess with any whitespace. Merge at your leisure. |
leidegre
force-pushed
the
feature/ide-gen-with-default-nodes
branch
from
b4651ed
to
a89ab85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards default nodes in IDE file generation code. As explained in this issue #345
I cannot use utility function
make_lookup_tablebecause I'm building a lookup table from an array of arrays. I made sure though that it does this the same way it would do it if you flattened the array and then passed it tomake_lookup_table.