-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: change slack success and fail messages #3923
base: master
Are you sure you want to change the base?
Conversation
This will work strangely on multiple hosts deploys. I think we need some sort of notion of "stages". |
@@ -76,8 +76,8 @@ | |||
|
|||
// Deploy message | |||
set('slack_text', '_{{user}}_ deploying `{{target}}` to *{{hostname}}*'); | |||
set('slack_success_text', 'Deploy to *{{target}}* successful'); | |||
set('slack_failure_text', 'Deploy to *{{target}}* failed'); | |||
set('slack_success_text', 'Deploy of `{{target}}` to *{{hostname}}* successful'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Showing hostname is not the best practise. We ascully want to show something like Deploy prod. Or deploy staging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got confused because in the start message the host is bold and the branch is as code
. In the success message suddenly the branch is bold.
What is a multiple host deploy? Deploying to two host in one go? Or just using multiple hosts so you can choose where to deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploying to two host in one go?
Yes.
OR just a host name with IP. And we better to use aliaas in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need a special magic config to determine the value of deployed hosts.
Slack message was as follows:
Where something like below was intended.
I changed it to:
Same for failed message.