Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change slack success and fail messages #3923

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: change slack success and fail messages #3923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64fd4e1
Fix: change slack success and fail messages
Aquive Oct 17, 2024
ee8af5e
Fix: Slack contrib docs for last commit
Aquive Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/slack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@

// Deploy message
set('slack_text', '_{{user}}_ deploying `{{target}}` to *{{hostname}}*');
set('slack_success_text', 'Deploy to *{{target}}* successful');
set('slack_failure_text', 'Deploy to *{{target}}* failed');
set('slack_success_text', 'Deploy of `{{target}}` to *{{hostname}}* successful');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing hostname is not the best practise. We ascully want to show something like Deploy prod. Or deploy staging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got confused because in the start message the host is bold and the branch is as code. In the success message suddenly the branch is bold.

What is a multiple host deploy? Deploying to two host in one go? Or just using multiple hosts so you can choose where to deploy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploying to two host in one go?

Yes.

OR just a host name with IP. And we better to use aliaas in this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need a special magic config to determine the value of deployed hosts.

set('slack_failure_text', 'Deploy of `{{target}}` to *{{hostname}}* failed');
set('slack_rollback_text', '_{{user}}_ rolled back changes on *{{target}}*');
set('slack_fields', []);

Expand Down
4 changes: 2 additions & 2 deletions docs/contrib/slack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Deploy message


```php title="Default value"
'Deploy to *{{target}}* successful'
'Deploy of `{{target}}` to *{{hostname}}* successful'
```


Expand All @@ -106,7 +106,7 @@ Deploy message


```php title="Default value"
'Deploy to *{{target}}* failed'
'Deploy of `{{target}}` to *{{hostname}}* failed'
```


Expand Down