[Design] appbar-bottom (navigation) 컴포넌트 추가 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woobottle
reviewed
Dec 26, 2023
src/constants/router.ts
Outdated
| @@ -6,4 +6,10 @@ export const ROUTER = { | |||
| RECORD: (id: string) => `/mission/${id}/stopwatch`, | |||
| STOP_WATCH: (id: string) => `/mission/${id}/stopwatch`, | |||
| }, | |||
| MYPAGE: { | |||
| ROOT: '/mypage', | |||
There was a problem hiding this comment.
이거 혹시 HOME으로 가면 어떨지 궁금해요!!
ROUTER.MYPAGE.HOME
/에서 HOME으로 쓰고 있어서 통일을 하면 어떨지 의견이 궁금합니도
woobottle
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
close #154
🎉 변경 사항
app-bar-bottom컴포넌트 추가🙏 여기는 꼭 봐주세요!
/으로 되어있습니다. 그런데 현재/경로는 저희 스플래시 화면인 상태입니다.Home경로가 밑과 같은 페이지인것으로 나타납니다!/경로를SPLASH등으로 변경하거나,/경로는Home으로 하고/splash경로(예시)로 스플래시 화면으로 보이게 해야할 것 같습니다.🌄 스크린샷