Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐ŸŽจ Stopwatch > 1์ฐจ MVP ํ™”๋ฉด์—์„œ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„ ์ˆ˜์ • #197

Merged
merged 1 commit into from
Dec 26, 2023
Merged

๐ŸŽจ Stopwatch > 1์ฐจ MVP ํ™”๋ฉด์—์„œ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„ ์ˆ˜์ • #197

merged 1 commit into from
Dec 26, 2023

Conversation

sumi-0011
Copy link
Member

@sumi-0011 sumi-0011 commented Dec 26, 2023 •
edited
Loading

๐Ÿค” ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

close #195

  • ์Šคํƒ‘์›Œ์น˜ ์† ์ปจํ…์ธ  ์ •๋ ฌ : ์ค‘์•™ -> ํ•˜๋‹จ ์ •๋ ฌ๋กœ ๋ณ€๊ฒฝ
  • ์Šคํƒ‘์›Œ์น˜ 10๋ถ„ ์‹ฌ๋ณผ ์•„์ด์ฝ˜ ๊ต์ฒด๋จ (as-is : lightning / to-be : 10mm-symbol)
  • ์Šคํƒ‘์›Œ์น˜ ๋ฏธ์…˜๋ช… ๊ฐ€๋กœํญ fixed ๊ฐ’ ์ค„์–ด๋“ฆ (as-is : 160px / to-be : 110px)

๐ŸŽ‰ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • lightning ์•„์ด์ฝ˜ ์ œ๊ฑฐ, 10mm-symbol ์•„์ด์ฝ˜ ์ถ”๊ฐ€

๐Ÿ™ ์—ฌ๊ธฐ๋Š” ๊ผญ ๋ด์ฃผ์„ธ์š”!

  • 10mm-symbol ์•„์ด์ฝ˜ ์ปดํฌ๋„ŒํŠธ์˜ ๊ฒฝ์šฐ ์ปดํฌ๋„ŒํŠธ ์ด๋ฆ„ ์ฒ˜์Œ์— ์ˆซ์ž๊ฐ€ ์˜ค๋ฉด ์•ˆ๋˜๋Š” ๊ด€๊ณ„๋กœ, TENMMSymbolcon์œผ๋กœ ํ•˜์˜€๋Š”๋ฐ, ๋‹ค๋ฅธ ์ข‹์€ ๋„ค์ด๋ฐ์ด ์žˆ๋‹ค๋ฉด ์•Œ๋ ค์ฃผ์„ธ์š”!

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
10mm-client-web โœ… Ready (Inspect) Visit Preview Dec 26, 2023 2:30pm

@github-actions GitHub Actions
Copy link
Contributor

๐Ÿš€storybook: https://656f59f07b8e48bf741b98e6-zdhzbubrzu.chromatic.com/

woobottle
woobottle approved these changes Dec 26, 2023
View reviewed changes
src/components/Icon/LightningIcon.tsx
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘๐Ÿป

@sumi-0011 sumi-0011 changed the title ๐ŸŽจ LightningIcon > 10mm symbol icon ๊ต์ฒด ๐ŸŽจ Stopwatch > 1์ฐจ MVP ํ™”๋ฉด์—์„œ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„ ์ˆ˜์ • Dec 26, 2023
@sumi-0011 sumi-0011 self-assigned this Dec 26, 2023
@sumi-0011 sumi-0011 added this to the 2์ฐจ MVP milestone Dec 26, 2023
@sumi-0011 sumi-0011 marked this pull request as ready for review December 26, 2023 14:35
@sumi-0011 sumi-0011 merged commit efd93f6 into develop Dec 26, 2023
5 checks passed
@sumi-0011 sumi-0011 deleted the design/stopwatch-2-mvp branch December 26, 2023 14:35
@github-actions GitHub Actions
Copy link
Contributor

๐Ÿš€storybook: https://656f59f07b8e48bf741b98e6-fuwruvgkma.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woobottle woobottle woobottle approved these changes

@wade3420 wade3420 Awaiting requested review from wade3420 wade3420 is a code owner

@JUNOSHON JUNOSHON Awaiting requested review from JUNOSHON

Assignees

@sumi-0011 sumi-0011

Labels
design style
Projects
None yet
Milestone
2์ฐจ MVP
2 participants
@sumi-0011 @woobottle