[Feat] 종료 미션 보관함 페이지 생성 #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
woobottle
reviewed
Feb 10, 2024
| @@ -5,6 +5,7 @@ import { MISSION_CATEGORY_LABEL } from '@/constants/mission'; | |||
|
|
|||
| function MissionHistoryBannerApi({ missionId }: { missionId: string }) { | |||
| const { data } = useGetMissionDetailNoSuspense(missionId); | |||
| console.log('data: ', data); | |||
| @@ -36,6 +36,7 @@ type QueryList = { | |||
| missionStack: { | |||
| missionId: string; | |||
| }; | |||
| finishedMissions: undefined; | |||
There was a problem hiding this comment.
쿼리키 관련 나중에 이야기 하고 싶은데
여유있을때 같이 이야기 해보시졍~
| const scrollAreaCss = css({ | ||
| overflowY: 'scroll', | ||
| height: 'calc(100vh - 24px - 44px)', | ||
| _scrollbar: { |
| @@ -4,7 +4,13 @@ interface UseModalProps { | |||
| initialOpen?: boolean; | |||
| } | |||
|
|
|||
| const useModal = ({ initialOpen = false }: UseModalProps = {}) => { | |||
| export interface UseModalReturn { | |||
woobottle
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
closed #509
🎉 변경 사항