Feature/#1/kakao social login setting #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmhyeonwoo
reviewed
Jul 2, 2024
|
|
||
| useEffect(() => { | ||
| // // FIXME: 백엔드 API에 따라 주소 수정 필요 | ||
| axios |
There was a problem hiding this comment.
해당 부분은 Axios 인터셉터에 정의되어있는 api로 호출해서 쓰면 좋을 것 같아요!
There was a problem hiding this comment.
넵 코드 확인하고 수정하겠습니다!
klmhyeonwoo
reviewed
Jul 2, 2024
src/app/login/KakaoLogin.tsx
Outdated
Comment on lines
2
to
3
| const REST_API_KEY: string = import.meta.env.REST_API_KEY; | ||
| const REDIRECT_URI: string = import.meta.env.REDIRECT_URI; |
There was a problem hiding this comment.
VITE_ 프리픽스를 앞에 명시해줘야 환경 변수가 잘 동작하지 않나요?! 🤔
There was a problem hiding this comment.
네네 맞습니다. 그 부분을 체크 못했네요!! 수정하겠습니다. 감사합니다~
klmhyeonwoo
reviewed
Jul 2, 2024
src/app/login/KakaoLogin.tsx
Outdated
Comment on lines
2
to
3
| const REST_API_KEY: string = import.meta.env.REST_API_KEY; | ||
| const REDIRECT_URI: string = import.meta.env.REDIRECT_URI; |
There was a problem hiding this comment.
Suggested change
| const REST_API_KEY: string = import.meta.env.REST_API_KEY; | |
| const REDIRECT_URI: string = import.meta.env.REDIRECT_URI; | |
| const REST_API_KEY: string = import.meta.env.VITE_REST_API_KEY; | |
| const REDIRECT_URI: string = import.meta.env.VITE_REDIRECT_URI; |
klmhyeonwoo
reviewed
Jul 2, 2024
src/app/login/KakaoLogin.tsx
Outdated
| const Login = () => { | ||
| const REST_API_KEY: string = import.meta.env.REST_API_KEY; | ||
| const REDIRECT_URI: string = import.meta.env.REDIRECT_URI; | ||
| const link: string = `https://kauth.kakao.com/oauth/authorize?client_id=${REST_API_KEY}&redirect_uri=${REDIRECT_URI}&response_type=code`; |
There was a problem hiding this comment.
Suggested change
| const link: string = `https://kauth.kakao.com/oauth/authorize?client_id=${REST_API_KEY}&redirect_uri=${REDIRECT_URI}&response_type=code`; | |
| const link: string = `https://kauth.kakao.com/oauth/authorize?client_id=${VITE_REST_API_KEY}&redirect_uri=${VITE_REDIRECT_URI}&response_type=code`; |
leeminhee119
approved these changes
Jul 2, 2024
src/app/login/KakaoLogin.tsx
Outdated
| const Login = () => { | ||
| const REST_API_KEY: string = import.meta.env.REST_API_KEY; | ||
| const REDIRECT_URI: string = import.meta.env.REDIRECT_URI; | ||
| const link: string = `https://kauth.kakao.com/oauth/authorize?client_id=${REST_API_KEY}&redirect_uri=${REDIRECT_URI}&response_type=code`; |
There was a problem hiding this comment.
값이 이미 문자열이라, 타입이 자동 추론돼서 생략해도 될 것 같습니당!
There was a problem hiding this comment.
제가 TS프로젝트가 처음이라... 민희님 말씀대로 추론이 가능한 경우에 생략과 그래도 확실한 명시 중에 어떤 방식이 좋은건가요?? 🤔
There was a problem hiding this comment.
저는 추론이 가능한 경우라면 코드 간결성을 위해 생략하는 게 좋다고 생각해요! vscode에서는 변수에 마우스 올리면 타입을 볼 수 있어서 따로 명시하지 않아도 된다고 생각합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
🧐 Issue number and link (참고)
📚 Reference (참조)