chore: #1 포크의 경우 main브랜치 이름 추가 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeminhee119
force-pushed
the
feature/1/build-workflow
branch
from
a252909
to
b059a4a
Compare
|
.. 라고 생각했는데, 왜 그래도 안될까요 🤨 |
klmhyeonwoo
reviewed
Jul 2, 2024
| @@ -4,7 +4,7 @@ import { useAtom } from "jotai"; | |||
| import { messageAtom } from "@/store/messageAtom.tsx"; | |||
|
|
|||
| function MainPage() { | |||
| const [message, setMessage] = useAtom(messageAtom); | |||
| const [message] = useAtom(messageAtom); | |||
There was a problem hiding this comment.
변수를 없애는 것도 방법인데, 추후에 사용하는거면 임시로 이런 방법도 있어요!
Suggested change
| const [message] = useAtom(messageAtom); | |
| const [message, _] = useAtom(messageAtom); |
지금 이 부분 때문에 빌드 실패나는데 잡아주셔서 감사합니다 😊
klmhyeonwoo
approved these changes
Jul 2, 2024
어랏 저거 추가해도 안되나요.. 🤔 |
klmhyeonwoo
reviewed
Jul 2, 2024
.github/workflows/build-test.yml
Outdated
| @@ -4,9 +4,11 @@ on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - depromeet/layer:main | |||
| pull_request: | |||
There was a problem hiding this comment.
이렇게 하면 되려나요?! 🫨
찾은 레퍼런스 자료 공유드립니다!
정리하면 pull_request 이벤트가 PR로 올라온 커밋에서 실행되는 반면 pull_request_target은 풀 리퀘스트에 의해서 실행되는 이벤트이지만 풀 리퀘스트가 머지 대상(target)으로 지정한 base를 기준으로 실행된다.
Suggested change
| pull_request: | |
| pull_request_target: |
참조 : https://blog.outsider.ne.kr/1541
There was a problem hiding this comment.
흠,, 보니까 애초에 포크한 PR은 신뢰할 수 없다고 판단해서 이 이벤트로도 빌드는 하지 말라고 하는 것 같네요..?! (Warning 참고)
-> 7/3 확인: 포크 PR 워크플로 작동!
donghunee
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏄🏼♂️ Summary (요약)
🫨 Describe your Change (변경사항)
🧐 Issue number and link (참고)
📚 Reference (참조)