Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1 포크의 경우 main브랜치 이름 추가 #9

Merged
merged 3 commits into from
Jul 3, 2024
Merged

chore: #1 포크의 경우 main브랜치 이름 추가 #9

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b059a4a
chore: #1 포크의 경우 main브랜치 이름 추가
leeminhee119 Jul 2, 2024
9fbdde3
fix: #1 안쓰는 변수 제거
leeminhee119 Jul 2, 2024
93bbcbc
fix: #1 포크 pr 제한 풀기
leeminhee119 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ on:
push:
branches:
- main
- depromeet/layer:main
pull_request:
Copy link
Member

@klmhyeonwoo klmhyeonwoo Jul 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 하면 되려나요?! 🫨
찾은 레퍼런스 자료 공유드립니다!

정리하면 pull_request 이벤트가 PR로 올라온 커밋에서 실행되는 반면 pull_request_target은 풀 리퀘스트에 의해서 실행되는 이벤트이지만 풀 리퀘스트가 머지 대상(target)으로 지정한 base를 기준으로 실행된다.

Suggested change
pull_request:
pull_request_target:

참조 : https://blog.outsider.ne.kr/1541

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 빠르다 !! 적용해볼게요

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member Author

@leeminhee119 leeminhee119 Jul 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠,, 보니까 애초에 포크한 PR은 신뢰할 수 없다고 판단해서 이 이벤트로도 빌드는 하지 말라고 하는 것 같네요..?! (Warning 참고)

-> 7/3 확인: 포크 PR 워크플로 작동!

branches:
- main
- depromeet/layer:main

jobs:
build:
Expand Down
Loading