Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Sync: Link #1672

Closed
scurker opened this issue Sep 11, 2024 · 1 comment · Fixed by #1675
Closed

Design Sync: Link #1672

scurker opened this issue Sep 11, 2024 · 1 comment · Fixed by #1675
Assignees
Labels
design sync Issues that need design synchronization rocket

Comments

@scurker
Copy link
Member

scurker commented Sep 11, 2024

The following changes need to be made to the .Link styles:

  • remove font-weight
  • remove all p .Link styles
  • remove display: inline-block

For links that include leading or trailing icons:

.Link:has(.Icon) {
  display: inline-flex;
  align-items: center;
  gap: var(--space-half);
  flex-wrap: wrap;
}

And remove from a styles from base.css:

  • font-weight

Link typography should generally be inheriting styles from css cascading.

The end result should be: All components that appear visually as Links should have a font-weight of 400.

@scurker scurker added the design sync Issues that need design synchronization label Sep 11, 2024
@ezirlingerDQ
Copy link

Please update link style definition to 16px (1rem), 150% line height, weight - regular. This is the same style definition as body default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sync Issues that need design synchronization rocket
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants