New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document design tokens #1204

Merged

orest-s merged 24 commits into develop from feat/document-design-tokens

Oct 20, 2023

Contributor

orest-s commented Sep 22, 2023

Closes #1050

orest-s added 8 commits

September 22, 2023 20:15


          feat: added utility function to get variables by the start name

27a6687


          feat: added spacing component

46a834a


          feat: added colors component

08306d2


          feat: added CSSParamsTable component

b35114d


          feat: added component to mdx-components

45b5266


          feat: added some missed colors

73b1414


          feat: added mdx files

201e545


          feat: removed console.log

2ed0f3a

orest-s requested review from a team as code owners

September 22, 2023 17:18

Contributor

github-actions bot commented Sep 22, 2023

Preview branch generated at https://feat-document-design-tokens.d1gko6en628vir.amplifyapp.com


          fix: a11y issues

2874fd2

scurker reviewed

View reviewed changes

Member

scurker left a comment

Thanks for putting this together! I have some different thoughts I need to mull on, and will try to review this later today.

docs/components/Colors.tsx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/colors.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/colors.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/colors.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/colors.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/colors.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/spacing.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/typography.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/typography.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

docs/pages/typography.mdx Outdated Show resolved Hide resolved

scurker reviewed

View reviewed changes

packages/styles/button.css Outdated Show resolved Hide resolved

scurker requested changes

View reviewed changes

Member

scurker left a comment

Thanks for putting this together! I know there's a lot of comments/requested changes but I appreciate the work put into this and it's a really great start.

docs/pages/colors.mdx Outdated Show resolved Hide resolved

docs/components/Colors.css Outdated Show resolved Hide resolved

docs/components/Colors.css Show resolved Hide resolved

docs/components/Colors.css Outdated Show resolved Hide resolved

docs/components/Colors.css Show resolved Hide resolved

docs/pages/spacing.mdx Outdated Show resolved Hide resolved

docs/pages/zIndex.mdx Outdated Show resolved Hide resolved

docs/pages/typography.mdx Outdated Show resolved Hide resolved

docs/pages/typography.mdx Outdated Show resolved Hide resolved

docs/pages/typography.mdx Outdated Show resolved Hide resolved

orest-s added 6 commits

October 4, 2023 18:54


          fix: removed console.log

e70260d


          fix: heading order

ae81ea8


          fix: revert fixing missing styles, since it will be done via separate PR

b0c7f41


          fix: description

d4c5ba3


          fix: using px instead of rems

498f7df


          feat: added foundations section for the tokens

768e1bc

orest-s added 5 commits

October 9, 2023 17:19


          feat: improved CssParamsTable, using renderExample and formatName fun…

cb200b1

…ctions


          fix: added some fixes for colors page

661aec5


          feat: changed spacing page, using table with examples

ee897b5


          feat: moved token pages to the foundations section and improved spaci…

4ca8eac

…ng and typography page


          fix: missed background color for spacing example

scurker reviewed

View reviewed changes

Member

scurker left a comment

This is looking really good! 2 small nits, and I noticed that I was getting the following error on the preview build:

Error accessing stylesheet: DOMException: Failed to read the 'cssRules' property from 'CSSStyleSheet': Cannot access rules

docs/pages/foundations/typography.mdx Outdated Show resolved Hide resolved

docs/pages/foundations/typography.mdx Outdated Show resolved Hide resolved

orest-s added 2 commits

October 11, 2023 19:25


          fix: nit

e3369cc


          fix: accessing external css stylesheets, which throws an error

5818f2a

scurker reviewed

View reviewed changes

Member

scurker left a comment

Code LGTM, the last thing is in the docs preview it looks like the css vars for spacing/typography isn't appearing.


          fix: excluding css stylesheet if it's on the same origin

ea06723

orest-s requested a review from scurker

October 17, 2023 13:18

scurker reviewed

View reviewed changes

docs/utils/getCssVariablesStartingWith.ts Outdated Show resolved Hide resolved


          fix: improved cross-origin check

b105607

scurker changed the title ~~feat(docs): document design tokens~~ docs: document design tokens

scurker approved these changes

View reviewed changes

Member

scurker left a comment

I updated the title to docs because we wouldn't want this to bump our cauldron version.

orest-s merged commit 2d41c7c into develop

8 checks passed

orest-s deleted the feat/document-design-tokens branch

October 20, 2023 15:15

Contributor

github-actions bot commented Oct 20, 2023

Preview branch generated at https://feat-document-design-tokens.d1gko6en628vir.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet