Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): synced TextField component with designs #1696

Merged
merged 10 commits into from
Oct 15, 2024
Merged

feat(styles): synced TextField component with designs #1696

merged 10 commits into from
Oct 15, 2024

Conversation

orest-s
Copy link
Contributor

@orest-s orest-s commented Sep 30, 2024

Closes: #1679

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1696.d15792l1n26ww3.amplifyapp.com

@orest-s orest-s marked this pull request as ready for review October 1, 2024 11:01
@orest-s orest-s requested review from a team as code owners October 1, 2024 11:01
scurker
scurker requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things.

Also design review needed from @dequelabs/cauldron-design

packages/styles/forms.css Outdated Show resolved Hide resolved
packages/styles/text-field-wrapper.css Show resolved Hide resolved
@orest-s @scurker
Update packages/styles/forms.css
109dce7 
Co-authored-by: Jason <jason@scurker.com>
shawnsharpDQ
shawnsharpDQ previously approved these changes Oct 1, 2024
View reviewed changes
Copy link

@shawnsharpDQ shawnsharpDQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orest-s no issues found.
@scurker I wanted to mention that we do not have a hover focus state for dark theme. Is that required and should be added? It looks like has never existed before.

scurker
scurker requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why some of the screenshots have changed, but everything generally looks good aside from the one blocking comment.

packages/styles/button.css Outdated Show resolved Hide resolved
@scurker scurker changed the title feat(styles): synced TextField component feat(styles): synced TextField component with designs Oct 15, 2024
@scurker scurker merged commit 1971a3b into develop Oct 15, 2024
9 checks passed
@scurker scurker deleted the feat/sync-text-field-styles branch October 15, 2024 18:43
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

@shawnsharpDQ shawnsharpDQ Awaiting requested review from shawnsharpDQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Sync: TextField
3 participants
@orest-s @scurker @shawnsharpDQ