Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): synced TextField component with designs #1696

Merged
merged 10 commits into from
Oct 15, 2024
Binary file modified e2e/screenshots/bottomsheet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/combobox-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/combobox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--bottomsheet.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--combobox-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--combobox.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--searchfield.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--select-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--select.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--textfield-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/dark--textfield.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/searchfield.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/select-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/select.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/textfield-error-.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/screenshots/textfield.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion packages/styles/button.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
--button-background-color-secondary-disabled: var(--gray-30);
--button-outline-color-secondary: var(--gray-90);
--button-background-color-secondary-active: var(--gray-30);
--button-border-color-secondary: var(--gray-40);

--button-background-color-error: var(--error);
--button-background-color-error-disabled: #db6379;
Expand Down Expand Up @@ -126,7 +127,7 @@ button.Link {
.Button--tertiary {
background-color: var(--button-background-color-secondary);
color: var(--button-text-color-dark);
border: 1px solid var(--field-border-color);
border: 1px solid var(--button-border-color-secondary);
}

.Button--tertiary:is(:not(:hover, :focus), [disabled], [aria-disabled='true']) {
Expand Down
4 changes: 2 additions & 2 deletions packages/styles/combobox.css
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
);
--text-field-wrapper-border-hover-color: var(
--combobox-input-border-hover-color,
var(--field-border-color-focus-hover)
var(--field-border-color-hover)
);
--text-field-wrapper-border-focus-glow-color: var(
--combobox-input-border-focus-glow-color,
Expand Down Expand Up @@ -78,7 +78,7 @@
);
--text-field-wrapper-border-hover-color: var(
--combobox-input-border-hover-color,
var(--field-border-color-focus-hover)
var(--field-border-color-hover)
);
--text-field-wrapper-border-focus-glow-color: var(
--combobox-input-border-focus-glow-color,
Expand Down
6 changes: 4 additions & 2 deletions packages/styles/forms.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
--field-border-color-error-hover: #c42f41;
--field-border-color-error-focus-glow: rgba(217, 50, 81, 0.7);
--field-border-color-disabled: rgba(204, 204, 204, 0.25);
--field-border-radius: 4px;
--field-background-color-disabled: var(--light-workspace-color);
--field-placeholder-color: var(--gray-50);
--field-required-text-color: var(--gray-60);
Expand Down Expand Up @@ -38,7 +39,7 @@
--field-background-color: var(--accent-medium);
--field-content-color: var(--white);
--field-border-color: #74818b;
--field-border-color-hover: var(--accent-info-light);
--field-border-color-hover: var(--accent-light);
--field-border-color-focus: var(--accent-info);
--field-border-color-focus-hover: var(--accent-info-light);
--field-border-color-focus-glow: var(--accent-info);
Expand Down Expand Up @@ -73,7 +74,6 @@ textarea,
[role='spinbutton'] {
width: 100%;
border: 1px solid var(--field-border-color);
border-bottom: 1px solid var(--field-border-color-underline);
margin-bottom: var(--space-half);
box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.05);
background-color: var(--field-background-color);
Expand Down Expand Up @@ -342,6 +342,7 @@ textarea.Field--has-error:focus:hover,
font-size: var(--field-font-size);
color: var(--field-content-color);
min-width: min(var(--input-min-width), 100%);
border-radius: var(--field-border-radius);
}

.Field__text-input[disabled],
Expand All @@ -358,6 +359,7 @@ textarea.Field--has-error:focus:hover,
padding: var(--space-half);
max-width: 500px;
color: var(--field-content-color);
border-radius: var(--field-border-radius);
}

.Field__textarea[disabled],
Expand Down
9 changes: 7 additions & 2 deletions packages/styles/search-field.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
);
--text-field-wrapper-border-hover-color: var(
--search-field-border-hover-color,
var(--field-border-color-focus-hover)
var(--field-border-color-hover)
);
--text-field-wrapper-border-focus-glow-color: var(
--search-field-border-focus-glow-color,
Expand Down Expand Up @@ -56,7 +56,7 @@
);
--text-field-wrapper-border-hover-color: var(
--search-field-border-hover-color,
var(--field-border-color-focus-hover)
var(--field-border-color-hover)
);
--text-field-wrapper-border-focus-glow-color: var(
--search-field-border-focus-glow-color,
Expand Down Expand Up @@ -92,3 +92,8 @@
.SearchField input::-webkit-search-cancel-button {
margin-left: var(--space-smallest);
}

.SearchField input {
border-top-left-radius: 0;
border-bottom-left-radius: 0;
}
1 change: 1 addition & 0 deletions packages/styles/select.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
padding: var(--space-three-quarters) var(--space-smallest);
padding-right: var(--space-large);
border: 1px solid var(--field-border-color);
border-radius: var(--field-border-radius);
font-family: Roboto;
font-weight: normal;
font-style: normal;
Expand Down
11 changes: 4 additions & 7 deletions packages/styles/text-field-wrapper.css
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
--text-field-wrapper-border-color: var(--field-border-color);
--text-field-wrapper-background-color: var(--field-background-color);
--text-field-wrapper-border-focus-color: var(--field-border-color-focus);
--text-field-wrapper-border-hover-color: var(
--field-border-color-focus-hover
);
scurker marked this conversation as resolved.
Show resolved Hide resolved
--text-field-wrapper-border-hover-color: var(--field-border-color-hover);
--text-field-wrapper-border-focus-glow-color: var(
--field-border-color-focus-glow
);
Expand All @@ -23,9 +21,7 @@
--text-field-wrapper-border-color: var(--field-border-color);
--text-field-wrapper-background-color: var(--field-background-color);
--text-field-wrapper-border-focus-color: var(--field-border-color-focus);
--text-field-wrapper-border-hover-color: var(
--field-border-color-focus-hover
);
--text-field-wrapper-border-hover-color: var(--field-border-color-hover);
--text-field-wrapper-border-focus-glow-color: var(
--field-border-color-focus-glow
);
Expand All @@ -51,7 +47,7 @@
display: flex;
align-items: center;
border: 1px solid var(--text-field-wrapper-border-color);
border-bottom: 1px solid var(--field-border-color-underline);
border-radius: var(--field-border-radius);
margin-bottom: var(--space-half);
box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.05);
background-color: var(--text-field-wrapper-background-color);
Expand All @@ -71,6 +67,7 @@
}

.TextFieldWrapper input {
border-radius: var(--field-border-radius);
font-size: var(--text-field-wrapper-font-size);
color: var(--text-field-wrapper-font-color);
}
Expand Down
Loading
Loading