feat: make the id param optional in GB setAttribute (#108)

deriv-com · Sep 3, 2024 · 8c8c8a3 · 8c8c8a3
1 parent 4e22280
commit 8c8c8a3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/analytics.ts b/src/analytics.ts
@@ -1,6 +1,6 @@
 import { Growthbook, GrowthbookConfigs } from './growthbook'
 import { RudderStack } from './rudderstack'
-import { TCoreAttributes, TEvents, TGrowthbookOptions } from './types'
+import { TCoreAttributes, TEvents, TGrowthbookAttributes, TGrowthbookOptions } from './types'
 
 type Options = {
     growthbookKey?: string
@@ -83,8 +83,7 @@ export function createAnalyticsInstance(options?: Options) {
 
         // Check if we have Growthbook instance
         if (_growthbook) {
-            _growthbook.setAttributes({
-                id: user_identity || getId(),
+            const config: TGrowthbookAttributes = {
                 country,
                 residence_country,
                 user_language,
@@ -96,7 +95,9 @@ export function createAnalyticsInstance(options?: Options) {
                 is_authorised,
                 url,
                 domain,
-            })
+            }
+            if (user_identity) config.id = user_identity
+            _growthbook.setAttributes(config)
         }
 
         core_data = {

diff --git a/src/types.ts b/src/types.ts
@@ -1,7 +1,7 @@
 import type { Context } from '@growthbook/growthbook'
 
 export type TGrowthbookAttributes = {
-    id: string
+    id?: string
     country?: string
     user_language?: string
     device_language?: string