fix(deriv_auth_ui): login button enabled on invalid email and password (

#366) * fix: update with latest master * chore: ignore dependent package lint * fix: login button enabled on invalid email and password
deriv-com · Dec 21, 2023 · 5109a0c · 5109a0c
1 parent e44a618
commit 5109a0c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/packages/deriv_auth_ui/example/analysis_options.yaml b/packages/deriv_auth_ui/example/analysis_options.yaml
@@ -22,8 +22,6 @@ linter:
   # `// ignore_for_file: name_of_lint` syntax on the line or in the file
   # producing the lint.
   rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
+    depend_on_referenced_packages: false
 # Additional information about this file can be found at
 # https://dart.dev/guides/language/analysis-options
diff --git a/packages/deriv_auth_ui/example/lib/features/login/services/example_login_service.dart b/packages/deriv_auth_ui/example/lib/features/login/services/example_login_service.dart
@@ -17,9 +17,7 @@ class ExampleLoginService extends BaseAuthService {
 
   @override
   Future<AuthorizeEntity> onLoginRequest(
-    GetTokensRequestModel request, [
-    Function? onInvalidJwtToken,
-  ]) async =>
+          {required GetTokensRequestModel request, String? userAgent}) async =>
       const AuthorizeEntity();
 
   @override

diff --git a/packages/deriv_auth_ui/lib/src/features/login/layouts/deriv_login_layout.dart b/packages/deriv_auth_ui/lib/src/features/login/layouts/deriv_login_layout.dart
@@ -293,7 +293,8 @@ class _DerivLoginLayoutState extends State<DerivLoginLayout> {
   }
 
   bool _isFormValid() =>
-      _getEmailValue().isNotEmpty && _passwordController.text.isNotEmpty;
+      _getEmailValue().isValidEmail &&
+      _passwordController.text.isValidLoginPasswordLength;
 
   String? _emailValidator(String? input) {
     if (_getEmailValue().isValidEmail) {