Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update_reference_to_git_dependencies #929

Merged
merged 33 commits into from
Dec 23, 2024

Conversation

ramin-deriv
Copy link
Contributor

Clickup link:
Fixes issue: #

This PR contains the following changes:

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@ramin-deriv ramin-deriv changed the title ramin/update_ta_package_pubspec chore(deriv_technical_analysis)ramin/update_ta_package_pubspec Dec 23, 2024
@ramin-deriv ramin-deriv changed the title chore(deriv_technical_analysis)ramin/update_ta_package_pubspec chore(deriv_technical_analysis): ramin/update_ta_package_pubspec Dec 23, 2024
@ramin-deriv ramin-deriv changed the title chore(deriv_technical_analysis): ramin/update_ta_package_pubspec refactor: update_reference_to_git_dependencies Dec 23, 2024
@ramin-deriv ramin-deriv merged commit 0da684d into deriv-com:master Dec 23, 2024
2 of 4 checks passed
@ramin-deriv ramin-deriv deleted the ramin/publish_ta_first branch December 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant