Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nada/advertiser registration issues #248

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Nada/advertiser registration issues #248

merged 8 commits into from
Aug 9, 2024

Conversation

nada-deriv
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10317180302

Details

  • 16 of 19 (84.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 85.328%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AdvertiserName/AdvertiserNameStats.tsx 12 15 80.0%
Totals Coverage Status
Change from base Build 10281500747: -0.1%
Covered Lines: 5732
Relevant Lines: 6245
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Preview Link: https://nada-advertiser-issu.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@nada-deriv nada-deriv merged commit 23222f5 into deriv-com:master Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@azmib-developer azmib-developer Awaiting requested review from azmib-developer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nada-deriv @coveralls @matin-deriv @farrah-deriv @ameerul-deriv