Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameerul / FEQ-2617 WS reconnection upon switching languages #369

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ameerul-deriv
Copy link
Contributor

@ameerul-deriv ameerul-deriv commented Sep 27, 2024

  • Updated api-hooks package
  • Changed logic to handle switching languages
  • Updated some components/hooks to refetch the data in the new connection after switching languages

Screenshot 2024-08-22 at 10 42 25 AM
Screenshot 2024-08-22 at 10 27 39 AM
Screenshot 2024-08-22 at 10 38 35 AM

Before

P2P.Guide.Get.started.disappears.mov
PaymentMethodCards.don.t.switch.language.mov
PaymentMethods.dropdown.not.changing.language.mov
ProfileBalance.titles.not.changing.language.mov

After

P2PGuide.Translation.fix.mov
PaymentMethodCards.Switching.languages.mov
PaymentMethods.dropdown.switches.language.mov
ProfileBalance.titles.switching.languages.fix.mov
Pages.tab.scrollable.mov

@coveralls
Copy link

coveralls commented Sep 27, 2024

Pull Request Test Coverage Report for Build 11339992351

Details

  • 50 of 52 (96.15%) changed or added relevant lines in 15 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 85.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/api/advert/p2p-advert/useAdvertList.ts 1 2 50.0%
src/pages/guide/screens/GettingStarted/GettingStarted.tsx 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
src/components/PaymentMethodField/index.ts 1 66.67%
src/hooks/api/advert/p2p-advert/useAdvertList.ts 1 33.33%
Totals Coverage Status
Change from base Build 11323980471: 0.2%
Covered Lines: 6471
Relevant Lines: 7010

💛 - Coveralls

@ameerul-deriv ameerul-deriv changed the title Feq 2617 ws reconnection upon switching language Ameerul / FEQ-2617 WS reconnection upon switching languages Sep 27, 2024
Copy link

Preview Link: https://FEQ-2617-ws-reconnec.p2p-standalone.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants