CSIT-1563/Prince/ initial implementation of freshchat #390
+456
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prince-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
wojciech-deriv and
farrah-deriv
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Filespackage-lock.json
package.json
|
prince-deriv
changed the title
ameerul-deriv
approved these changes
Oct 30, 2024
| }, 10); | ||
|
|
||
| if (!isGBLoaded || (isFreshChatEnabled && !freshChat?.isReady)) { | ||
| return null; |
There was a problem hiding this comment.
shouldn't we return livechat by default?
farrah-deriv
approved these changes
Nov 4, 2024
nada-deriv
approved these changes
Nov 5, 2024
|
Preview Link: https://freshchat-implementa.p2p-standalone.pages.dev
|
farrah-deriv
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
countryis standardized viacloudflarefor proper trigger of growthbook flagNote:I need help for initial review, this is awaiting for the new hooks coming from deriv-app to properly handle the toggle of the current active chat widget.