Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(codebase): improve modularity, readability and maintainability #21

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

derl30n
Copy link
Owner

@derl30n derl30n commented Jan 15, 2024

This update aims to elevate the codebase to the next level by adopting OOP style and by following common coding guidelines and good practices.

No features have been added/removed.

This also comes with a downside, the config file structure changes drastically and requires the user to add their configuration all over again.

There is no plan to change the style and design of the config again.

@derl30n
Copy link
Owner Author

derl30n commented Jan 31, 2024

OOP doesn't seem to be feasible with FiveM's LUA integration. For that matter, I am looking into a C# solution instead.

Pushing and releasing with the latest working OOP approach also doesn't feel right, since the entire configuration changes and will change again with a C# solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant