Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs due to pyflyby cell #20

Merged
merged 5 commits into from
Oct 30, 2023
Merged

Fix bugs due to pyflyby cell #20

merged 5 commits into from
Oct 30, 2023

Conversation

divyansshhh
Copy link
Contributor

@divyansshhh divyansshhh commented Sep 6, 2023 •
edited
Loading

This fixes a bug where multiple clicks of the TidyImportButton would modify the notebook in unexpected ways. Some of these were -

  1. Outputs of cells being mismatched when reconstructing the notebook.
  2. Addition of random cells above and below the pyflyby tagged cell.
  3. Mutliple clicks of the TidyImportButton would keep adding extra lines in the pyflyby cell.

@divyansshhh divyansshhh requested a review from mlucool September 6, 2023 10:01
mlucool
mlucool reviewed Sep 13, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
@divyansshhh
Copy link
Contributor Author

I spent some more time here and the TidyImports button is now completely idempotent

@divyansshhh
Copy link
Contributor Author

This needs deshaw/pyflyby#267

@divyansshhh divyansshhh merged commit 325f755 into 4.x Oct 30, 2023
1 check passed
@divyansshhh divyansshhh deleted the chore/fix-tidy-imports-bug branch October 30, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlucool mlucool mlucool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyansshhh @mlucool