Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyflyby messages check during nb cleanup #23

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix pyflyby messages check during nb cleanup #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10f5c60
Fix pyflyby messages check during nb cleanup
Feb 28, 2024
9b3794b
Update package version and CHANGELOG
Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## [5.1.2](https://github.com/deshaw/jupyterlab-pyflyby/compare/v5.1.1...v5.1.2) (2024-02-28)

### Fixed

- Fix pyflyby messages check during nb cleanup

## [5.1.1](https://github.com/deshaw/jupyterlab-pyflyby/compare/v5.1.0...v5.1.1) (2024-02-20)

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@deshaw/jupyterlab-pyflyby",
"version": "5.1.1",
"version": "5.1.2",
"description": "A labextension to integrate pyflyby with notebooks",
"keywords": [
"jupyter",
Expand Down
4 changes: 2 additions & 2 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ class PyflyByWidget extends Widget {
// just have pyflyby messages
if (
line !== '' &&
line !== PYFLYBY_START_MSG &&
line !== PYFLYBY_END_MSG
line !== PYFLYBY_START_MSG.trim() &&
line !== PYFLYBY_END_MSG.trim()
) {
shouldDelete = false;
}
Expand Down
Loading