Make TidyImports + notebook integration idemponent #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order of imports was not correct on the first click of the TidyImports button. This PR fixes that issue.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 66.43% 66.55% +0.11%
==========================================
Files 25 25
Lines 7884 7923 +39
==========================================
+ Hits 5238 5273 +35
- Misses 2646 2650 +4
☔ View full report in Codecov by Sentry. |
mlucool
approved these changes
Oct 20, 2023
dshivashankar1994
pushed a commit
that referenced
this pull request
Jan 31, 2024
Order of imports was not correct on the first click of the TidyImports button. This PR fixes that issue. Co-authored-by: Divyansh Choudhary <choudhdi@deshaw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order of imports was not correct on the first click of the TidyImports button. This PR fixes that issue.