Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tidy-imports failure when black is used and pyproject.toml is missing #289

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix tidy-imports failure when black is used and pyproject.toml is missing #289

merged 2 commits into from
Jan 30, 2024

Conversation

krassowski
Copy link
Contributor

Fixes #288

Adds tests to ensure that black is actually run on Import when requested, tests on the black config parsing logic, and tests against the scenario in which pyproject.toml is missing.

@dshivashankar1994 dshivashankar1994 merged commit 58ff86f into deshaw:master Jan 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshivashankar1994 dshivashankar1994 dshivashankar1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidy-imports --black fails with no pyproject.toml (PyInf#11819)
2 participants
@krassowski @dshivashankar1994