defined a dynamic paramater for colors map in the color function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkarambit
reviewed
Nov 2, 2020
There was a problem hiding this comment.
I really don't think that this change is necessary because the very reason we wrote this function in the first place was to avoid having to write both map_name and property_name each time we need to get a value. I think this change defeats the very purpose for which this function was written in the first place and that's why this PR should be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When more than one map is created, say $colors and $more-colors, it would make sense to define a dynamic map parameter in the function rather than hardcode it. This way, we can simply pass in the map name and its key as arguments to the function.