Add packages needed for desidatadocs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sbailey
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Looks good, thanks. Having just commented in #71 about hesitancy to bring in new dependencies, I'll justify approving these "new" dependencies because:
- They are non-algorithmic packages, needed just for installing documentation, thus the impact of deprecating them someday is much less than packages needed by core algorithmic code.
- We effectively already depend on them, we just don't automatically install them, so this PR isn't making the dependency situation any worse than it already is.
Note: we are not planning on making a new desiconda environment for Kibo, so this is for the further future, not the imminent future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #72.