Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickquasars sets every EXPID=0 #438

Open
ngbusca opened this issue Oct 19, 2018 · 3 comments
Open

quickquasars sets every EXPID=0 #438

ngbusca opened this issue Oct 19, 2018 · 3 comments

Comments

@ngbusca
Copy link

ngbusca commented Oct 19, 2018

quickquasars sets all the EXPID to zero. This is a problem for picca since pairs at rp == 0 are rejected. While we improve this on the picca side (not before DR14 papers are out) it would be good to fix this on quickquasars too.

I've included a "hack" in picca to avoid this issue (currently in branch picca_nersc_submit) by setting the expid to the nightid (the latter is different for each line of sight).

@andreufont
Copy link
Contributor

Is EXPID the equivalent of FIBERID, or the equivalent of THINGID? I'm guessing FIBERID?

@ngbusca
Copy link
Author

ngbusca commented Oct 19, 2018

There's no exact equivalent when using coadded data. Picca was using it as the PLATEID, meaning that pairs with equal EXPID and both FIBERID < 500 (trivially satisfied for realistic desidata but not for quickquasars where FIBERID can be very large) and rp==0 are rejected.

@ngbusca
Copy link
Author

ngbusca commented Oct 19, 2018

By the way, the NIGHT is also the same for all quickquasars spectra-16 files, so I've set the "effective" plate in picca as the FIBERID instead of the NIGHT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants