Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize basis_templates tagging procedure #554

Open
weaverba137 opened this issue Nov 10, 2021 · 3 comments
Open

Formalize basis_templates tagging procedure #554

weaverba137 opened this issue Nov 10, 2021 · 3 comments
Assignees

Comments

@weaverba137
Copy link
Member

Prior to basis_templates/v3.0, tags contained a checksum file. However more recent tags do not contain this file. Uploading and downloading very large binary files with svn is always a bit tricky, so the checksum file helps protect against corruption.

Here are some non-binding suggestions:

  1. Include the checksum file, but use sha256sum and call it, e.g., basis_templates_v3.3.sha256sum. That is, include the tag in the name.
  2. It would not be a bad idea to have a checksum file for trunk.
  3. Create some automation for preparing basis_templates/trunk for tagging, including creating the checksum file, modifying basis_templates_trunk.sha256sum as needed.
  4. Include the creation of the tag itself in the automation.
  5. Include a post-tag "bump" that restores basis_templates_trunk.sha256sum.

Here's some code that illustrates this:

cd basis_templates/trunk
rm basis_templates_trunk.sha256sum
sha256sum *.fits > basis_templates_trunk.sha256sum
svn commit -m "Update checksum file"
svn rename basis_templates_trunk.sha256sum basis_templates_v3.3.sha256sum
svn commit -m "Prepare checksum file for next tag"
cd ..
svn copy trunk tags/v3.3
svn commit -m "Tagging basis_templates/v3.3"
cd trunk
svn rename basis_templates_v3.3.sha256sum basis_templates_trunk.sha256sum
svn commit -m "restore trunk checksum file after tag"
@sbailey
Copy link
Contributor

sbailey commented Nov 11, 2021

This sounds good. I suggest wrapping that in a script, perhaps kept in basis_templates svn rather than desisim, for tagging + checksumming basis_templates correctly. We could use that to make a new tag just to cleanup the checksum situation for the most recent tag.

@weaverba137
Copy link
Member Author

@moustakas, @sbailey, are there ever going to be new tags of basis_templates?

@moustakas
Copy link
Member

I think it's not inconceivable that we revisit the desisim infrastructure and develop new basis templates going into desi-2 and beyond, so I wouldn't count it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants