Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix circular import with trace_shifts #2084

Merged
merged 1 commit into from
Aug 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion py/desispec/image_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from desispec.qproc.qextract import qproc_boxcar_extraction
from desispec.qproc.qsky import qproc_sky_subtraction
from desispec.qproc.qfiberflat import qproc_apply_fiberflat
from desispec.trace_shifts import compute_dx_from_cross_dispersion_profiles

@numba.jit
def numba_proj(image,x,sigma,flux) :
Expand Down Expand Up @@ -75,6 +74,9 @@ def compute_image_model(image,xytraceset,fiberflat=None,fibermap=None,with_spect

log=get_logger()

# this is done here to avoid circular import
from desispec.trace_shifts import compute_dx_from_cross_dispersion_profiles

if fit_x_shift :
t0=time.time()
log.info("fitting dx ...")
Expand Down
Loading