Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spectra coaddition and cosmic masking #2377

Merged
merged 59 commits into from
Oct 7, 2024
Merged

Fix spectra coaddition and cosmic masking #2377

Show file tree
Hide file tree
Changes from 58 commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
6561cc4
initial fix
segasai Sep 17, 2024
d911f70
cleanup
segasai Sep 17, 2024
a3abe0c
clarify the code
segasai Sep 25, 2024
491840a
get rid of old variable
segasai Sep 25, 2024
6207f1c
add a test that would trigger the bug
segasai Sep 27, 2024
ca818df
add an advanced test that checks the that relationship between
segasai Sep 27, 2024
39089e6
unused variable
segasai Sep 28, 2024
b2f71bb
a couple more tests
segasai Sep 28, 2024
86dcd70
add another test
segasai Sep 29, 2024
cf3ff51
make variable names more explicit
segasai Sep 29, 2024
5e6c013
move some duplicated code between coadd/coadd_cameras into its own fu…
segasai Sep 29, 2024
5ba2743
further get rid of duplicated code
segasai Sep 29, 2024
176c7ca
add missing log=get_logger()
Sep 30, 2024
4aae55b
add docs for mask_cosmics
segasai Oct 1, 2024
ae2e569
fix doc
segasai Oct 1, 2024
67962a7
fix incorrect behaviour of coadd_cameras when mask is not present
segasai Oct 1, 2024
fc8abf2
fix another bug in the coadd_cameras
segasai Oct 1, 2024
5fd5f47
fix coadd_cameras in a similar fashion to coadd()
segasai Oct 1, 2024
9409a3a
allow the test to generate spectra with multiple desi arms
segasai Oct 1, 2024
29e6d7b
make sure pixel are aligned in the multi arm test spectra
segasai Oct 1, 2024
1cd2542
fix the coadd_cameras recent changes
segasai Oct 1, 2024
1c914f0
fix test error
segasai Oct 1, 2024
cfb8966
update the coadd_cameras test so it test the exact correctness
segasai Oct 1, 2024
26895ff
simplify the logic in coadd() to avoid multiple
segasai Oct 1, 2024
a308dab
produce correct resolution matrix even for pixels that are flagged
segasai Oct 1, 2024
0d37f14
put common functionality in separate function
segasai Oct 1, 2024
526e298
add a check that we do things correctly when all pixels are masked
segasai Oct 1, 2024
a6a5d28
replace equality by allclose
segasai Oct 2, 2024
d947fb0
fix the cosmic masking issue
segasai Oct 2, 2024
b0febb8
change the way the cosmic threshold is defined
segasai Oct 2, 2024
07683d9
if we are masking a cosmic using gradient we must mask both pixels
segasai Oct 2, 2024
dd74fc1
add missing import
Oct 2, 2024
b7396fa
correctly deal with masked pixels when coadd()'ing
segasai Oct 3, 2024
49ab8b5
add tests of known coadd bugs
Oct 3, 2024
5848546
Merge branch 'resol_fix' of https://github.com/desihub/desispec into …
Oct 3, 2024
f8163c8
fix previous commit
segasai Oct 3, 2024
f149fe0
Merge branch 'resol_fix' of https://github.com/desihub/desispec into …
Oct 3, 2024
d9062cc
fix the masking in coadd_cameras()
segasai Oct 3, 2024
01eee32
Merge branch 'resol_fix' of https://github.com/desihub/desispec into …
Oct 3, 2024
ac1b9c1
fix test
Oct 3, 2024
8c2f367
fix the last failing tests
segasai Oct 3, 2024
388dee4
fix tests comments
segasai Oct 3, 2024
7031fb8
fix the bug in the original implementation and the new
segasai Oct 3, 2024
78acd70
a bit of cleanup.
segasai Oct 3, 2024
7bc6b68
a bit more cleanup
segasai Oct 3, 2024
6382c00
use cosmics_nsig=0 to disable cosmic masking
segasai Oct 3, 2024
5b2056e
add a final test of the coadd_cameras with cosmics
segasai Oct 3, 2024
3d17312
hopefully final commit.
segasai Oct 3, 2024
7b2b5ab
cover the last line of coadd_cameras by the test
segasai Oct 3, 2024
84e1183
insert space into print
segasai Oct 3, 2024
0ffcc4a
put some protection against coadding of spectra that
segasai Oct 3, 2024
987d359
add more comments
segasai Oct 4, 2024
4c08364
update comments
segasai Oct 4, 2024
d8811d7
docstring updates
Oct 4, 2024
c4d7d01
fix the bug with masking + add a test
segasai Oct 4, 2024
4d67246
resolve whitespace merge conflict
Oct 4, 2024
a161a7d
update comment ot make more legible
segasai Oct 4, 2024
1ae5f61
Merge branch 'resol_fix' of https://github.com/desihub/desispec into …
Oct 4, 2024
f3bc12b
docstring formatting and whitespace
Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading