Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import speed of light from scipy #478

Merged
merged 1 commit into from
Mar 25, 2019
Merged

import speed of light from scipy #478

merged 1 commit into from
Mar 25, 2019

Conversation

londumas
Copy link
Contributor

Move to a common definition of speed of light. Step toward fixing issue desihub/desisim#477.

@londumas londumas requested a review from sbailey March 23, 2019 17:37
@londumas londumas changed the title Change definition of speed of light import speed of light from scipy Mar 23, 2019
@geordie666
Copy link
Contributor

@londumas: The code looks good, and I ran the QA through to completion. So, no need for a review from @sbailey.

@geordie666 geordie666 merged commit f7df92e into master Mar 25, 2019
@geordie666 geordie666 deleted the same_speedoflight branch March 25, 2019 22:32
qmxp55 pushed a commit to qmxp55/desitarget that referenced this pull request Feb 12, 2020
@geordie666
Merge pull request desihub#478 from desihub/same_speedoflight
9536f37 
import speed of light from scipy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbailey sbailey Awaiting requested review from sbailey

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@londumas @geordie666